Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv64: Avoid F and V instruction generation #300

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

retrage
Copy link
Contributor

@retrage retrage commented Dec 9, 2023

As reported in issue #299, the latest RHF goes boot loop since nightly-2023-06-07 Rust toolchain. This is because the recent Rust generates code that includes F and V extensions, which we need to enable these features on startup. This commit disables generation of these extensions as a workaround.

Fixes #299.

@retrage retrage requested a review from rbradford December 9, 2023 09:02
Copy link
Member

@rbradford rbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rbradford
Copy link
Member

I think the wget is failing to download the aarch64 binary - like cloud-hypervisor/cloud-hypervisor#6006

@retrage retrage force-pushed the 2023-12-09-riscv64-fixes branch from e20922a to b27c71b Compare December 12, 2023 11:05
Signed-off-by: Akira Moroo <retrage01@gmail.com>
As reported in issue cloud-hypervisor#299, the latest RHF goes boot loop since
`nightly-2023-06-07` Rust toolchain. This is because the recent Rust
generates code that includes F and V extensions, which we need to enable
these features on startup. This commit disables generation of these
extensions as a workaround.

Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage retrage force-pushed the 2023-12-09-riscv64-fixes branch from b27c71b to 62be56b Compare December 13, 2023 00:52
@retrage retrage merged commit c3d6de6 into cloud-hypervisor:main Dec 13, 2023
5 checks passed
@retrage retrage deleted the 2023-12-09-riscv64-fixes branch December 13, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boot Loop with RISC-V
2 participants