Boot from memory device path #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbradford
force-pushed
the
2023-12-18-boot-from-memory-device-path
branch
from
93ec0f8 to
ba896c6
Compare
retrage
approved these changes
Dec 29, 2023
Convert the EFI device path protocol structure into a Rust structure in order to be able to handle different device path types (e.g. memory backed) in the future. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Rather than construct the device path when creating the image handle do so earlier so that ultimately a NULL path could be provided in the case of loading from memory. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Add a DevicePath::generate() method to generate the device path from the parsed device path. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Previously the path in the FileDevicePathProtocol was limited to 128 ascii characters. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
This will prevent it clashing when generating other types of device paths. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Grub will load the kernel into memory and ask the firmware to parse that as a PE binary. In order to reuse the existing infrastructure the memory range provided is turned into a struct that implements the fat::Read trait. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Remove some duplicated code for loading an image by extracting it out to its own function. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
rbradford
force-pushed
the
2023-12-18-boot-from-memory-device-path
branch
from
ba896c6 to
70e286b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRUB on (at least RISC-V) loads the guest kernel directly into memory and then
expects the firmware to parse it from there - it does this by using a device
path of type PCI and subtype memory mapped.
With this change the Linux kernel boots on RISC-V if the kernel command line is
modified to specify a fixed rootfs as there are issues with the initramfs.