Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch arm64 tests to self-hosted GitHub Actions runner #316

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

retrage
Copy link
Contributor

@retrage retrage commented Feb 23, 2024

It looks like we have a self-hosted arm64/linux GitHub Actions runner (cloud-hypervisor/cloud-hypervisor#6221).

Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage retrage requested a review from rbradford February 23, 2024 11:19
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Copy link
Member

@rbradford rbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

- if: ${{ matrix.coreboot-tests }}
name: Run coreboot integration tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - I saw this the other day when I was reviewing the output.

matrix:
include:
- runner: ubuntu-22.04
coreboot-tests: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind doing something like variant: coreboot here and something like variant: no coreboot - will produce nicer actions titles - otherwise - nice use of matrix!

@rbradford rbradford merged commit 25ac707 into cloud-hypervisor:main Feb 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants