-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update toolchain to nightly-2024-05-13 #335
Merged
retrage
merged 12 commits into
cloud-hypervisor:main
from
retrage:2024-05-15-update-toolchain
May 20, 2024
Merged
build: Update toolchain to nightly-2024-05-13 #335
retrage
merged 12 commits into
cloud-hypervisor:main
from
retrage:2024-05-15-update-toolchain
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 2024 edition disallows references to `static mut`. Instead, we should wrap `static mut` with `SyncUnsafeCell`. Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Use of the unsafe functions can be replaced by `Default::default()`. Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
The `next_cluster()` reports incorrect cluster value in release build due to optimization. This commit fixes the issue by replacing use of unsafe functions. Signed-off-by: Akira Moroo <retrage01@gmail.com>
With this update, some of the target json definitions need to be updated, and some experimental functions are updated. Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
retrage
force-pushed
the
2024-05-15-update-toolchain
branch
from
May 20, 2024 13:04
1aef8fd
to
fa13c03
Compare
retrage
changed the title
[WIP] build: Update toolchain to nightly-2024-05-13
build: Update toolchain to nightly-2024-05-13
May 20, 2024
rbradford
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you very much. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Rust toolchain to nightly-2024-05-13 with fixing several build errors/warnings.