Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efi: Refactor EFI layer #337

Merged
merged 5 commits into from
May 27, 2024
Merged

efi: Refactor EFI layer #337

merged 5 commits into from
May 27, 2024

Conversation

retrage
Copy link
Contributor

@retrage retrage commented May 26, 2024

This PR proposes a refactoring of the EFI layer to:

  • Get rid of definitions that are already defined in r-efi
  • Split src/efi/mod.rs into multiple files for readability
  • Remove multiple page size constant definitions

retrage added 5 commits May 26, 2024 10:58
@retrage
efi/alloc: Add alloc_pool and free_pool
8aa4a0e 
Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage
efi/alloc: Use r-efi constants
49edbf2 
Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage
efi/block: Use r-efi constants
028a9c8 
Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage
efi: Break down mod.rs into multiple files
4d0510b 
Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage
efi/alloc: Use page size defined in layout.rs
e823068 
Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage retrage marked this pull request as ready for review May 26, 2024 11:21
@retrage retrage requested a review from rbradford May 26, 2024 11:21
rbradford
rbradford approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@rbradford rbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@retrage retrage added this pull request to the merge queue May 27, 2024
Merged via the queue into cloud-hypervisor:main with commit 01f098c May 27, 2024
7 checks passed
@retrage retrage deleted the 2024-05-25-refactor-efi-protocols branch June 2, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbradford rbradford rbradford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retrage @rbradford