Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdt: enumerate all memory nodes present #346

Merged

Conversation

thomasbarrett
Copy link

It is possible for the device tree to have multiple memory nodes. Iterate through all regions defined by all memory nodes.

@thomasbarrett thomasbarrett force-pushed the multiple-fdt-memory-nodes branch from fc55458 to 83531ed Compare August 19, 2024 23:03
@thomasbarrett
Copy link
Author

This fixes cloud-hypervisor/cloud-hypervisor#6632

Copy link
Contributor

@retrage retrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing it. It looks good to me. I have a few minor change requests.

src/fdt.rs Outdated Show resolved Hide resolved
src/fdt.rs Outdated Show resolved Hide resolved
It is possible for the device tree to have multiple memory nodes. Iterate
through all regions defined by all memory nodes.

Signed-off-by: Thomas Barrett <tbarrett@crusoe.ai>
@thomasbarrett thomasbarrett force-pushed the multiple-fdt-memory-nodes branch from 83531ed to 08e879f Compare August 20, 2024 05:57
@retrage
Copy link
Contributor

retrage commented Aug 21, 2024

It looks like the arm64 CI runner is not started.

@retrage retrage added this pull request to the merge queue Aug 24, 2024
Merged via the queue into cloud-hypervisor:main with commit c6d6d39 Aug 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants