pe: Improve PE Loader Relocation #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes loading error reported in issue #73. Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
According to PE/COFF format spec., base relocation BlockSize includes PageRVA and BlockSize fields. This commit fixes to set the followed Type/Offset block offset correctly. Signed-off-by: Akira Moroo <retrage01@gmail.com>
|
@retrage I've triggered a rebuild in case the CI failure was a flake. |
rbradford
approved these changes
Jan 22, 2021
|
@josephlr ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves PE relocation support.
4c2696a and 10ef5a7 are small fixes based on the PE/COFF format specification. 4c2696a fixes the panic reported in issue #73.
794caf6 changes the loader behavior to load to the preferred address if the ImageBase in the PE header is a non-zero value.
If it is not specified, it loads at the binary at the default address
0x20_0000.