Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sru: manual verification on azure of gh-529, 539, 494 #159

Merged

Conversation

blackboxsw
Copy link
Collaborator

Validate:

sleep 30
retry_ssh_command $IP "cloud-init status --wait --long" 5
ssh "${SSHOPTS[@]}" $IP -- cloud-init status --wait --long
echo "--- TEST: EXPECT NO KVP dump logs in cloud-init.log" #bbsw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications to typical azure-sru script to validate cloud-int canonical/cloud-init#529

echo "REBOOTING TO Confirm boot extra timeout across reboot LP: #1830740" #bbsw
ssh "${SSHOPTS[@]}" $IP -- sudo reboot || true
ssh "${SSHOPTS[@]}" $IP -- cloud-init status --wait --long
echo "--- TEST: BEGIN EXPECT Long boot time LP: #1830740"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications to typical azure-sru script to validate canonical/cloud-init#539

sleep 60
ssh "${SSHOPTS[@]}" $IP -- cloud-init status --wait --long
ssh "${SSHOPTS[@]}" $IP -- sudo cat /run/cloud-init/result.json
echo "--- TEST: BEGIN EXPECT to find KVP dump logs in cloud-init.log" #bbsw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sleep 60
retry_ssh_command $IP "cloud-init status --wait --long" 5
echo 'After reboot'
echo "--- TEST: BEGIN EXPECT no delayed boot time LP: #1830740" #bbsw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff -urN previous-network.out upgrade-network.out
echo '------- TEST: END Expect driver directives in diff previous-network to post-upgrade-network expect ------'

echo '--- TEST: Expect success count of 2 for temporary_hostname' #bbsw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
}
--- TEST: BEGIN EXPECT to find KVP dump logs in cloud-init.log
2020-09-09 16:26:50,291 - azure.py[DEBUG]: Dumping cloud-init.log file to KVP
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found kvp upload logs

detail:
DataSourceAzure [seed=/var/lib/waagent]
--- TEST: BEGIN EXPECT Long boot time LP: #1830740
Startup finished in 6.058s (kernel) + 11.818s (userspace) = 17.877s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's that value expected ? It seems way smaller than the other releases

Copy link
Collaborator Author

@blackboxsw blackboxsw Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasmoura good eyes. And yes I should have qualified the test message to mention xenial is unaffected (because we only render fallback network config on Xenial (dhcp on eth0) instead of networking from IMDS. So, it shouldn't affect this release unless someone has custom images with apply_network_config: true.

@blackboxsw blackboxsw merged commit 443c3f3 into cloud-init:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants