Skip to content

Send exApp name and version in User-Agent header for requests to nextcloud #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcelklehr opened this issue Jan 16, 2025 · 4 comments · Fixed by #329
Closed

Send exApp name and version in User-Agent header for requests to nextcloud #327

marcelklehr opened this issue Jan 16, 2025 · 4 comments · Fixed by #329

Comments

@marcelklehr
Copy link

Describe why it is important and where it will be useful

For analysing performance bottlenecks and behvior in general, it would be useful to know which request comes from which exApp.

Describe your proposed solution

Send the exApp name and version in the user-agent header to Nextcloud.

Describe alternatives you've considered, if relevant

.

Additional context

No response
@bigcat88
Copy link
Member

Something like "httpx/{HTTPX_VERSION} ExApp/{EX_APP_ID} Version/{EX_APP_VERSION}" ?

Also cc @kyteinsky @edward-ly

@marcelklehr
Copy link
Author

Yeah, that'd be great!

@bigcat88
Copy link
Member

Added custom header ExApp/test-deploy/1.1.0 (httpx/0.24.1) of this type, because it is easier to parse with regex

@bigcat88 bigcat88 mentioned this issue Jan 19, 2025
Merged
bigcat88 added a commit that referenced this issue Jan 19, 2025
@bigcat88
set custom "User-Agent" for ExApps (#329)
19fe459 
Fixes #327

Changes proposed in this pull request:

* Added a custom header in the format `ExApp/test-deploy/1.1.0
(httpx/0.24.1)` to help "system administrators" identify which requests
are taking a long time to complete.
@marcelklehr
Copy link
Author

🎉 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set custom "User-Agent" for ExApps cloud-py-api/nc_py_api
2 participants
@marcelklehr @bigcat88