Skip to content

TalkAPI: part2 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 2, 2023
Merged

TalkAPI: part2 #111

merged 5 commits into from
Sep 2, 2023

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Sep 1, 2023

Changes proposed in this pull request:

  • +reaction API
  • +delete_message
  • send_message return value was corrected.
  • +rename_conversation
  • +get_conversation_by_token
  • +set_conversation_password, set_conversation_public, set_conversation_notify_lvl, set_conversation_readonly, set_conversation_fav, set_conversation_description

…e` return value

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #111 (514c8ed) into main (ad6ba5d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   99.70%   99.71%           
=======================================
  Files          28       29    +1     
  Lines        2374     2446   +72     
=======================================
+ Hits         2367     2439   +72     
  Misses          7        7           
Files Changed Coverage Δ
nc_py_api/talk_bot.py 100.00% <ø> (ø)
nc_py_api/_talk_api.py 100.00% <100.00%> (ø)
nc_py_api/nextcloud.py 100.00% <100.00%> (ø)
nc_py_api/talk.py 100.00% <100.00%> (ø)

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
Copy link
Member Author

bigcat88 commented Sep 2, 2023

What we leave for next versions:

  • Avatar support
  • Polls Management
  • Attachments support
  • Other miscellaneous stuff

@bigcat88 bigcat88 merged commit ed09642 into main Sep 2, 2023
@bigcat88 bigcat88 deleted the talk-part2 branch September 2, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant