Skip to content

files: added url quote to mkdir and delete #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Conversation

bigcat88
Copy link
Member

Fixes #191 .

Looks like this error was introduced in 0.7.0 version, where I refactored all code.

Fixed and adjusted tests suite to detect this

Tomorrow will check what else DAV methods affected by this error and fix that in separate PR.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (549f058) 99.93% compared to head (4c46086) 99.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          37       37           
  Lines        4500     4501    +1     
=======================================
+ Hits         4497     4498    +1     
  Misses          3        3           
Files Coverage Δ
nc_py_api/_version.py 100.00% <100.00%> (ø)
nc_py_api/files/files.py 100.00% <100.00%> (ø)

@bigcat88 bigcat88 merged commit f29e3bb into main Dec 26, 2023
@bigcat88 bigcat88 deleted the mkdir-delete-quote-url branch December 26, 2023 20:53
bigcat88 added a commit that referenced this pull request Dec 27, 2023
Ref #193

The same as in #192 but for all other DAV methods.
Tests were expanded to catch this case.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All special chars (like #) should be UrlEncoded
1 participant