Skip to content

skip OCS parsing when status == NO CONTENT #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2024
Merged

skip OCS parsing when status == NO CONTENT #197

merged 2 commits into from
Jan 1, 2024

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Jan 1, 2024

This code were not working:

nc.ocs("GET", "/ocs/v2.php/core/whatsnew")

this PR fixes it, for OCS that return Http::STATUS_NO_CONTENT we return empty list.

In addition added ALL API scope, ref: nextcloud/app_api/pull/190

Previous commit: 8fd175a was added fast to just implement ALL API scope tests in AppAPI repo.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fd175a) 99.82% compared to head (b42948c) 99.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   99.82%   99.84%   +0.02%     
==========================================
  Files          39       39              
  Lines        4599     4603       +4     
==========================================
+ Hits         4591     4596       +5     
+ Misses          8        7       -1     
Files Coverage Δ
nc_py_api/_session.py 100.00% <100.00%> (+0.32%) ⬆️
nc_py_api/ex_app/defs.py 100.00% <100.00%> (ø)

@bigcat88 bigcat88 merged commit 5278ce5 into main Jan 1, 2024
@bigcat88 bigcat88 deleted the ocs-204-status branch January 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant