Skip to content

add creation date to fs node info #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SunnyFarmDay
Copy link
Contributor

@SunnyFarmDay SunnyFarmDay commented Feb 9, 2025

Changes proposed in this pull request:

*Added creation date for the fs node info
*Edit default request to also get creation date

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.48%. Comparing base (b97f20a) to head (c9e4075).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nc_py_api/files/__init__.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   94.57%   94.48%   -0.10%     
==========================================
  Files          46       46              
  Lines        5368     5383      +15     
==========================================
+ Hits         5077     5086       +9     
- Misses        291      297       +6     
Files with missing lines Coverage Δ
nc_py_api/files/_files.py 98.60% <100.00%> (+0.01%) ⬆️
nc_py_api/files/__init__.py 97.97% <53.84%> (-1.73%) ⬇️

@bigcat88
Copy link
Member

Thanks for the PR. Can you modify the tests a little bit - so that this is covered by them?
In theory, you just need to do the same as for "last_modified" in the tests - if it's not too much trouble.

@bigcat88 bigcat88 merged commit 0f8566c into cloud-py-api:main Feb 15, 2025
13 checks passed
bigcat88 added a commit that referenced this pull request Feb 15, 2025
Related PR: #335

Signed-off-by: bigcat88 <bigcat88@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants