Skip to content

enabled AppAPIAuthMiddleware for websockets(Nextcloud 32+) #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

bigcat88
Copy link
Member

ExApps starting with Nextсloud 32 are planned to have websockets support - we enable authentication in advance, so that there is time to rebuild ExApps.

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@bigcat88 bigcat88 merged commit 62ff275 into main Feb 15, 2025
12 checks passed
@bigcat88 bigcat88 deleted the feat/exapps/websocket branch February 15, 2025 08:11
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (0f8566c) to head (c03cdb6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nc_py_api/ex_app/integration_fastapi.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   94.48%   94.59%   +0.11%     
==========================================
  Files          46       46              
  Lines        5383     5383              
==========================================
+ Hits         5086     5092       +6     
+ Misses        297      291       -6     
Files with missing lines Coverage Δ
nc_py_api/ex_app/integration_fastapi.py 24.51% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant