Skip to content

removed events_listener; added basic test for webhooks_listener #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

bigcat88
Copy link
Member

Starting with Nextcloud 30 there is a webhooks_listener app that is enabled by default and supports both regular requests and requests from ExApps!

It has much more and better functionality than events_listener in AppAPI, and we will remove events_listener for Nextcloud 32 from AppAPI.

In this PR I am removing events_listener and reworking the tests for events_listener into basic tests for webhooks_listener.

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@bigcat88 bigcat88 force-pushed the del-events_listener branch 2 times, most recently from 7483d55 to 2d70877 Compare April 14, 2025 12:35
Signed-off-by: bigcat88 <bigcat88@icloud.com>
@bigcat88 bigcat88 force-pushed the del-events_listener branch from 2d70877 to 06e4f59 Compare April 14, 2025 12:45
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (0965823) to head (06e4f59).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   94.52%   95.13%   +0.61%     
==========================================
  Files          46       45       -1     
  Lines        5389     5325      -64     
==========================================
- Hits         5094     5066      -28     
+ Misses        295      259      -36     
Files with missing lines Coverage Δ
nc_py_api/nextcloud.py 96.26% <ø> (-0.08%) ⬇️
nc_py_api/webhooks.py 94.84% <100.00%> (+40.40%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 merged commit 8142d7f into main Apr 14, 2025
13 checks passed
@bigcat88 bigcat88 deleted the del-events_listener branch April 14, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants