Skip to content

Update integration_fastapi.py #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Conversation

BerengarWLehr
Copy link
Contributor

Correct usage of fnmatch for ignoring some paths

Fixes #356 .

Correct usage of fnmatch for ignoring some paths

Signed-off-by: Berengar W. Lehr <Berengar.Lehr@uni-jena.de>
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (1e667d4) to head (c18a29f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nc_py_api/ex_app/integration_fastapi.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files          45       45           
  Lines        5325     5325           
=======================================
  Hits         5066     5066           
  Misses        259      259           
Files with missing lines Coverage Δ
nc_py_api/ex_app/integration_fastapi.py 24.51% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88
Copy link
Member

bigcat88 commented May 1, 2025

Hello. I am curious, how did you find this?

Thanks for the PR.

@bigcat88 bigcat88 merged commit ebce575 into cloud-py-api:main May 1, 2025
13 checks passed
@BerengarWLehr
Copy link
Contributor Author

I use a REST API as communication interface upstream (for Nextcloud/App API) but also downstream to provide files hosted in NC for further processing on our cluster and after processing the other way around to receive the results via POST before they are handed over to NC. But I couldn't figure out the NC auth mechanism, so I looked for a way to disable it. I had to disable the whole sub route (/downstream/$file_id) but as (/downstream/*) didn't work I took a dive into the code.

@bigcat88
Copy link
Member

bigcat88 commented May 3, 2025

Very interesting.

I wish you good luck in development, and we are always glad to receive new PRs here or in AppAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter disable_for does not work (as expected)
2 participants