Fix problem with UnexpectedFrameEnd raise
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grk are you able to say how you found this? did your code crash? do you know how to reproduce the situation? |
|
I messed up my config and tried to connect to the mqtt port of our rabbitmq instance 🤦🏻 |
dentarg
reviewed
Feb 15, 2024
lib/amqp/client/connection.rb
Outdated
| @@ -443,7 +443,7 @@ def establish(socket, user, password, vhost, options) | |||
|
|
|||
| type, channel_id, frame_size = buf.unpack("C S> L>") | |||
| frame_end = buf.getbyte(frame_size + 7) | |||
| raise UnexpectedFrameEndError, frame_end if frame_end != 206 | |||
| raise UnexpectedFrameEnd, frame_end if frame_end != 206 | |||
There was a problem hiding this comment.
Actually, this is still not correct, it should be Error::UnexpectedFrameEnd, noticed this when writing a test for this, I will push it to this branch soon
dentarg
changed the title
UnexpectedFrameEnd raise
|
I think there's another use that's missing the Error namespace: https://github.com/cloudamqp/amqp-client.rb/blob/main/lib/amqp/client/connection.rb#L185 |
|
You're right, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.