Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC #30

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

RPC #30

wants to merge 11 commits into from

Conversation

carlhoerberg
Copy link
Member

High level client support for RPC using direct reply queues.

@carlhoerberg carlhoerberg marked this pull request as ready for review June 12, 2024 17:03
@spuun
Copy link
Member

spuun commented Jun 13, 2024

Maybe we should have some optional argument for message/queue properties for both Client#rpc_call, Client#rpc_server and RPCClient#call? Or is that too low level?

@carlhoerberg
Copy link
Member Author

Wondering if rpc_call should be skipped, and recommend use of RPCClient instead. It's important to close the RPCClient after use though, otherwise channel leak.

@spuun
Copy link
Member

spuun commented Jun 14, 2024

Wondering if rpc_call should be skipped, and recommend use of RPCClient instead. It's important to close the RPCClient after use though, otherwise channel leak.

I don't think it's a problem to have both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants