Added error handling for IO error #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlhoerberg can you take a look at this |
|
When to expect a release with this code update ? I have similar problem, amqproxy remains blocked when rabbitmq cluster connection timeouts. |
|
@cdudevops It has been released now, with v0.8.8 |
dentarg
added a commit
that referenced
this pull request
Oct 3, 2023
This change also removes the code added in #104 The motivation behind that is * IO:_Error that happens in Upstream#connect is raised as Upstream::Error * IO::Error that happens in Upstream#read_loop is rescued in that method * IO::Error that happens in Client#read_loop is raised as Client::Error Adds an integration test with the php-amqp client run via Docker Compose and Toxiproxy. Close #118 Close #111 Close #98
dentarg
added a commit
that referenced
this pull request
Oct 11, 2023
This change also removes the code added in #104 The motivation behind that is * IO:_Error that happens in Upstream#connect is raised as Upstream::Error * IO::Error that happens in Upstream#read_loop is rescued in that method * IO::Error that happens in Client#read_loop is raised as Client::Error Adds an integration test with the php-amqp client run via Docker Compose and Toxiproxy. Close #118 Close #111 Close #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding error message and close connection for clients when the connection between RabbitMQ and AMQProxy is closed.
To reproduce.
This PR will ensure error is logged, and client is disconnected (as connection is broken to the cluster).