Update current client in Upstream#read_loop
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced by #128
The current client is updated by the server / pool, when there is a new connection:
amqproxy/src/amqproxy/server.cr
Line 75 in 8462a50
amqproxy/src/amqproxy/pool.cr
Line 25 in 8462a50
Close #135
Made it easy to run the specs in Docker as they use
sudoand needs an RabbitMQ instance running – specs weren't completely stable for me when running in macOS. This makes it much easier to start fresh. For CI, this should be the same as we were already using thecontainer:keyword.