-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server settings for replication #547
Conversation
79bdde1
to
5071009
Compare
Main benchmark PR benchmark Keep in mind, these numbers are not representative of LavinMQ's peak performance. |
2d3eaae
to
5071009
Compare
55c2412
to
92b1023
Compare
6ff9af3
to
19a91b9
Compare
@viktorerlingsson this is the solution i worked on with @carlhoerberg yesterday. I added the wait_for_followers channel, which works if i take it slow with the followers, and don't have an agressive max_lag limit (around 10000b) |
f70dfd6
to
65b0c7d
Compare
856784e
to
3ea75bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bebb411
to
ad09683
Compare
7df8592
to
8136d05
Compare
9576048
to
14ec15e
Compare
0d6dacd
to
b672109
Compare
8fb27b6
to
5c625f4
Compare
spec/replication_spec.cr
Outdated
when done.receive | ||
fail "Should not receive message" | ||
when timeout(0.1.seconds) | ||
#ugly hack to release replicator from waiting for lag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to work around spec_helpser
s after_each()
that calls server.stop
here.. because server.stop
only calls replicator.clear
, which will not finish if we are waiting for lag.
5c625f4
to
50ea08a
Compare
WHAT is this pull request doing?
Adds properties
min_followers
andmax_lag
to the Config class and the values are parsed fromlavinmq.ini
The values are then conditioned in
vhost.cr
via the replication servers newwait_for_max_lag
. You cannot publish to a queue if you have less followers connected thanmin_followers
or if min_followers amount of followers have more lag thanmax_lag
.Fixes #674
HOW can this pull request be tested?
Start LavinMQ and configure the values in your config file, connect too few followers and try to publish.