Bugfix: Use federated queue's name if upstream queue name is empty #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When federation parameters are stored queue is stored as an empty string if no value is given. This caused the upstream queue name to be declared with empty string as name, which means that the queue name will be auto generated. This change will treat both nil and empty string as "no value" and fallback to use the federated queues' name.
|
Main benchmark PR benchmark Keep in mind, these numbers are not representative of LavinMQ's peak performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
When an federation upstream is created without queue name the queue name on the upstream server was auto generated (amq.gen-*) because empty string was passed in the declare call.
This will extend the nil check of queue name to also check for empty string.
HOW can this pull request be tested?