Bugfix corrupt dlx headers #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
reviewed
Sep 22, 2023
spec/dlx_spec.cr
Outdated
| msg = wait_for { q.get } | ||
|
|
||
| x_death = msg.properties.headers.not_nil!["x-death"].as(Array(AMQ::Protocol::Field)) | ||
| x_death.inspect |
There was a problem hiding this comment.
I kinda want that there so that the code would actually crash with amq-protocol 1.1.9. Without it this spec just fails the comparison, and I think it's safer to also know that we can output the whole array.
There was a problem hiding this comment.
We could change it to x_death.inspect.should be_a(String) so it looks more like a spec I guess :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Fixes a bug where messages that where dead-lettered multiple times would cause memory errors because of an issue in amq-protocol.cr - cloudamqp/amq-protocol.cr#14
HOW can this pull request be tested?
Run the spec.