remove dead code #584
Merged
remove dead code #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
force-pushed
the
remove_unreachables
branch
from
877ca8f to
c443e1b
Compare
| @@ -40,12 +40,6 @@ module LavinMQ | |||
| end | |||
| end | |||
|
|
|||
| def each(&) | |||
There was a problem hiding this comment.
Because forward_missing_to further up? Maybe remove that instead
There was a problem hiding this comment.
we currently use each_value for shovels, instead of its own each
why remove forward_missing_to and exchange each_value for each instead of just removing each?
| else raise UnknownHashAlgoritm.new | ||
| end | ||
| end | ||
|
|
||
| class UnknownHashAlgoritm < Exception; end |
There was a problem hiding this comment.
Then drop this too i guess
There was a problem hiding this comment.
Still used higher up in file
kickster97
force-pushed
the
remove_unreachables
branch
from
28effe6 to
4f92bdf
Compare
viktorerlingsson
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Removes unreachable and dead code found with
crystal tool unreachable src/lavinmq.crDisclaimer: I have done this mainly guided by specs and the crystal tooling. I have also run snowstorm for
image: cloudamqp/lavinmq:pr-584Might be good to have someone on Linux and Windows to try out locally
HOW can this pull request be tested?
Run crystal spec
Run snowstorm with
image: cloudamqp/lavinmq:pr-584