Use persisted sorting/query information when loading table #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
reviewed
Dec 21, 2023
There was a problem hiding this comment.
I know RabbitMQ mgmt works like this but IMO this goes against how "web" works. E.g. if i click "Queues" in the menu I expect to end up with a "fresh view", not a view with some old filters active. With this change there is no way to "reset" the view without fiddling with the url in the url bar.
However, the referenced issue should be fixed.
Maybe we can change or URLs in the menu to contain a default filter? Like, add #page=1? Or is it better with some kind of reset filter button?
|
I don't know if that's what is expected, if i pull up a google sheet i expect the sheet to be sorted the way when i left it. |
carlhoerberg
force-pushed
the
persist-table-sorting
branch
from
486c3e3 to
dae5a82
Compare
Before all sorting etc was reset
|
I'll merge this as I think it makes the situation better than what it currently is at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Fixes #599
HOW can this pull request be tested?
Open a table view, eg queues, sort on eg. ready msgs, click on the Queue menu item again, the sorting should be the same.