Add more logging when loading definitions #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlhoerberg
approved these changes
Jan 8, 2024
spuun
force-pushed
the
logging-during-definition-loading
branch
from
75ed63e to
a307b76
Compare
spuun
force-pushed
the
logging-during-definition-loading
branch
from
deab9c7 to
899ef2c
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
If something failed during definitions loading it was hard to debug because the lack of logs. This will add more logging.
E.g. the bug that #620 fixes would have been much easier to find with this logging.
HOW can this pull request be tested?
Create a bunch of queues, exchanges and bindings and restart LavibMQ. Use log level
traceto see all logs.