deliver packet not msg from session #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snichme
commented
Nov 14, 2024
src/lavinmq/mqtt/session.cr
Outdated
| dup: env.redelivered, | ||
| qos: qos, | ||
| retain: retained, | ||
| topic: msg.routing_key.tr(".", "/") |
There was a problem hiding this comment.
@spuun is this .tr really correct?
There was a problem hiding this comment.
I don't think you need to convert between topic and routing key here. I think we're storing it as topic.
But if it's a routing key you want to convert . to /.
There was a problem hiding this comment.
yep thats a rest that i forgot to remove (and i removed it now form mqtt-poc)
There was a problem hiding this comment.
removing the tr then.
WDYT of the change otherwise?
kickster97
approved these changes
Nov 14, 2024
snichme
force-pushed
the
mqtt-deliver-packet-not-msg
branch
from
ead9b8a to
f073732
Compare
kickster97
pushed a commit
that referenced
this pull request
Nov 21, 2024
* deliver packet not msg from session * it's already a topic, no convert needed * fixes
kickster97
pushed a commit
that referenced
this pull request
Dec 18, 2024
* deliver packet not msg from session * it's already a topic, no convert needed * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessiondeliversMQTT:Publishinstead ofEnvelopeto consumer