Add WaitGroup to ensure consumer has sent all before removing itself #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snichme
approved these changes
Nov 18, 2024
|
Does this impact performance? |
Can't say it's noticeable. I guess benchmarks are in margin of error. This fix is what's needed for the "flush fiber" I've been playing around with, and that gives a 10-15% increased throughput. |
Okay, nice! 👍 |
viktorerlingsson
approved these changes
Nov 18, 2024
spuun
force-pushed
the
dont-remove-consumer-to-early
branch
from
f326bd1 to
9b44a23
Compare
spuun
force-pushed
the
dont-remove-consumer-to-early
branch
from
9b44a23 to
bb26f7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
I'm not sure we've run into this potential bug, but this is a solution to make sure the consumer has written all to socket before it's removing itself from a queue. The bug may trigger if it's the last consumer because then the queue will unmap its segments, but the consumer may still have references to a mapped segment that it tries to write to socket, resulting in a crash.
HOW can this pull request be tested?
Uhm... yolo? Should try to add specs for this.