Message deduplication #854
Open
+390
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
snichme
force-pushed
the
message-deduplication
branch
from
b42efc9 to
3b7828d
Compare
|
Documentation for the website: https://gist.github.com/snichme/40a33df7ea9a02c9a7d77a5c81d1f52d |
kickster97
reviewed
Nov 21, 2024
kickster97
approved these changes
Nov 25, 2024
viktorerlingsson
approved these changes
Nov 26, 2024
snichme
force-pushed
the
message-deduplication
branch
from
2ee7ba3 to
cbd08d4
Compare
carlhoerberg
reviewed
Dec 4, 2024
carlhoerberg
reviewed
Dec 9, 2024
|
I think the cache needs to be thread-safe? |
snichme
force-pushed
the
message-deduplication
branch
from
43e7c26 to
fb2fb4b
Compare
@spuun For it to work properly now or to support MT later on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Implementation for message deduplication on exchanges.
It works for any exchange type and is enabled by setting the argument
x-message-deduplication = trueon any exchange.Features
Fixes #833
HOW can this pull request be tested?
Specs.