Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Add rabbitmq dependency #1

Merged
merged 2 commits into from
Jun 9, 2017
Merged

Add rabbitmq dependency #1

merged 2 commits into from
Jun 9, 2017

Conversation

Gsantomaggio
Copy link

@Gsantomaggio Gsantomaggio commented Jun 9, 2017

  • Add rabbit dependency, so it is possible to execute:make run-broker
  • Change git branch to stable ( we should always stable as reference, and not a specific version)
  • Change random function ( note for 3.6.x we should not use random, ssl and time functions directly but use the compatmodules: rand_compat ,ssl_compact, time_compact )

Gabriele Santomaggio added 2 commits June 9, 2017 15:44
Change the dependencies to stable
Fix this warn: 'random' module is deprecated
@carlhoerberg carlhoerberg merged commit 49296a9 into cloudamqp:master Jun 9, 2017
@Ayanda-D
Copy link
Contributor

NOTE: These changes won't work when the plugin is built from master. rand_compat ,ssl_compact and time_compact are only implemented in rabbitmq-common stable branch, and not master, hence testing this results in modules not being found/undef errors. Plugin now also requires a new branch stable to be built from, which I've just created, for the build to also make correct reference to the stable branch of required deps 👍

@Gsantomaggio
Copy link
Author

yep! if we want to follow the RAbbitMQ standards, we should create stable branch for 3.6.x and master for 3.7.x.

Just to clarify:
The master does not need the *_compat modules because of rabbitmq/rabbitmq-server#546

The 3.6.x versions need *_compat modules because have to support old Erlang versions https://www.rabbitmq.com/which-erlang.html

@Ayanda-D
Copy link
Contributor

Ayanda-D commented Jun 10, 2017

Initial implementation was to work from master while avoiding these strict dependencies introduced by rabbitmq-components.mk. We're currently emphasising on 3.6.x compatibility most importantly, hence this had to be quickly corrected. Working on 3.7.x compatibility in parallel.

NOTE: I've released a robust and system-ready 0.2 release bearing these dependency changes and aspects in mind. Leaving it on 0.2 for a while we further enhance 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants