Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit testing #294

Merged
merged 13 commits into from
Apr 10, 2024
Merged

Add more unit testing #294

merged 13 commits into from
Apr 10, 2024

Conversation

mihaelabalutoiu
Copy link
Contributor

This PR adds more unit tests for the following modules:

  • replicas/api.py
  • replica_tasks_executions/api.py
  • replica_cron/api.py
  • replica_cron/rpc/client.py
  • replica_cron/rpc/server.py
  • regions/api.py
  • providers/api.py
  • providers/factory.py
  • providers/provider_utils.py
  • providers/replicator.py
  • providers/backup_writers.py

Dany9966
Dany9966 requested changes Mar 22, 2024
View reviewed changes
coriolis/tests/providers/test_backup_writers.py Show resolved Hide resolved
coriolis/tests/providers/test_backup_writers.py Outdated Show resolved Hide resolved
coriolis/tests/providers/test_backup_writers.py Outdated Show resolved Hide resolved
coriolis/tests/providers/test_backup_writers.py Outdated Show resolved Hide resolved
coriolis/tests/providers/test_backup_writers.py Outdated Show resolved Hide resolved
coriolis/tests/replica_cron/rpc/test_server.py Show resolved Hide resolved
coriolis/tests/replica_cron/rpc/test_server.py Outdated Show resolved Hide resolved
coriolis/tests/replica_cron/rpc/test_server.py Outdated Show resolved Hide resolved
coriolis/tests/replica_cron/rpc/test_server.py Outdated Show resolved Hide resolved
coriolis/tests/replicas/test_api.py Outdated Show resolved Hide resolved
Dany9966
Dany9966 requested changes Apr 8, 2024
View reviewed changes
coriolis/tests/providers/test_backup_writers.py Outdated Show resolved Hide resolved
coriolis/tests/providers/test_backup_writers.py Outdated Show resolved Hide resolved
coriolis/tests/providers/test_replicator.py Outdated Show resolved Hide resolved
coriolis/tests/providers/test_replicator.py Outdated Show resolved Hide resolved
@mihaelabalutoiu
Add unit tests for replicas/api.py module
6d334b8 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for replica_tasks_executions/api.py
be09c03 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for replica_cron/api.py module
1a27574 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for replica_cron/rpc/client.py
f3358b2 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for replica_cron/rpc/server.py
d2e5a4c 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for regions/api.py module
d791425 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for providers/api.py module
3861e65 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for providers/factory.py module
a0a5798 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for providers/provider_utils.py
90e67e6 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for providers/replicator.py module
5549bac 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Add unit tests for providers/backup_writers.py
d19f8de 
module

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Fixed the uri variable to avoid double slashes
42ab846 
when adding device name

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@mihaelabalutoiu
Remove the dublicate declaration of the
9f3c974 
`remote_port` variable

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@Dany9966 Dany9966 merged commit 2af562b into cloudbase:master Apr 10, 2024
4 checks passed
@mihaelabalutoiu mihaelabalutoiu deleted the add-more-unit-tests branch April 10, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dany9966 Dany9966 Dany9966 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaelabalutoiu @Dany9966