Skip to content

Commit

Permalink
Don't add aditional labels to GH runner
Browse files Browse the repository at this point in the history
For now, the aditional labels would only contain the job ID that triggered
the creation of the runner. It does not make sense to add this label to the
actual runner that registeres against github. We can simply use it internally
by fetching it from the DB.

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
  • Loading branch information
gabriel-samfira committed Jul 3, 2023
1 parent 0ab8f73 commit 6c06afb
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions runner/pool/pool.go
Original file line number Diff line number Diff line change
Expand Up @@ -743,10 +743,6 @@ func (r *basePoolManager) addInstanceToProvider(instance params.Instance) error
labels = append(labels, r.controllerLabel())
labels = append(labels, r.poolLabel(pool.ID))

if len(instance.AditionalLabels) > 0 {
labels = append(labels, instance.AditionalLabels...)
}

jwtValidity := pool.RunnerTimeout()

entity := r.helper.String()
Expand Down

0 comments on commit 6c06afb

Please sign in to comment.