Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add controller.go unit tests and Fix database.go typo #14

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Add controller.go unit tests and Fix database.go typo #14

merged 2 commits into from
Sep 13, 2022

Conversation

mihaelabalutoiu
Copy link
Contributor

@mihaelabalutoiu mihaelabalutoiu commented Sep 13, 2022 •
edited
Loading

Add controller.go unit tests
Fix database.go typo

gabriel-samfira
gabriel-samfira requested changes Sep 13, 2022
View reviewed changes
database/sql/controller_test.go Outdated Show resolved Hide resolved
@mihaelabalutoiu
Copy link
Contributor Author

Add controller.go unit tests Fix database.go typo

Thank you for the suggestion. I made this change and also fixed the typo for database.go.

@mihaelabalutoiu mihaelabalutoiu changed the title Add controller.go unit tests Add controller.go unit tests and Fix database.go typo Sep 13, 2022
@gabriel-samfira gabriel-samfira merged commit 777c41e into cloudbase:main Sep 13, 2022
@mihaelabalutoiu mihaelabalutoiu deleted the add-db-ctrl-unit-tests branch September 13, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-samfira gabriel-samfira gabriel-samfira requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaelabalutoiu @gabriel-samfira