Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout logic #152

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix timeout logic #152

merged 1 commit into from
Aug 14, 2023

Conversation

mihaelabalutoiu
Copy link
Contributor

If everything is fine, we return early from the Wait functions.

Just breaking the loop executes the code following the loop, which is meant to be executed only on timeout exceeded.

@mihaelabalutoiu
Fix timeout logic
6b77979 
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@gabriel-samfira gabriel-samfira merged commit 10cc209 into cloudbase:main Aug 14, 2023
@mihaelabalutoiu mihaelabalutoiu deleted the fix-timeout-logic branch August 14, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaelabalutoiu @gabriel-samfira