Fix e2e secrets generation #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 22, 2023 11:17
Some integration tests workflows failed with: ``` Error: Invalid format 'ORG_WEBHOOK_SECRET=***' ``` or ``` Error: Invalid format 'GARM_PASSWORD=***' ``` Workflow runs logs: * https://github.com/cloudbase/garm/actions/runs/5920389694/job/16051606203#step:7:26 * https://github.com/cloudbase/garm/actions/runs/5908193226/job/16027297143#step:7:26 This is a transient error, as it only happens sometimes. I suspect that sometimes there is some illegal sequence of characters in the random generated strings. Thus, the GitHub actions logic to parse the environment fails. This change removes the special characters that would have a special meaning in bash, from the `randomStringGenerator` function, in hopes to fix the transient issue. Signed-off-by: Ionut Balutoiu <ibalutoiu@cloudbasesolutions.com>
This seems to be related to the distribution used by the GitHub `ubuntu-latest` runners, as I can't reproduce it locally on my Ubuntu 22.04 server. An useful discussion on this topic: https://stackoverflow.com/questions/48725875/is-there-a-workaround-for-this-broken-pipe-error Signed-off-by: Ionut Balutoiu <ibalutoiu@cloudbasesolutions.com>
Remove extra spaces from the `integration-tests.yml` file. Signed-off-by: Ionut Balutoiu <ibalutoiu@cloudbasesolutions.com>
gabriel-samfira
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some integration tests workflows failed with:
or
Workflow runs logs:
This is a transient error, as it only happens sometimes.
I suspect that sometimes there is some illegal sequence of characters
in the random generated strings. Thus, the GitHub actions logic to
parse the environment fails.
This change removes the special characters that would have a special
meaning in bash, from the
randomStringGeneratorfunction, in hopesto fix the transient issue.
Also, silence
trystderr messages, and fix spacing in theintegration-tests.ymlfile.