feat: scale down idle runners #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was wondering why you closed it yesterday 😄 . Will have a proper look in the morning! |
|
This is great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically scales down superfluous runners.
There are a number of scenarios where we end up with more runners than the idle pool size.
E.g. when you change the min_pool_size ..
This PR is an example of how we could scale down runners that are not needed at the moment.
What do you think?
The runners are deleted not all at once but each
PoolScaleDownIntervalhalf of the surplus is deleted until we hitmin_idle_runnersSo far, neither the Iterval (1 Minute) nor the percentage of runners to be removed is configurable.
Michael Kuhnt michael.kuhnt@mercedes-benz.com Mercedes-Benz Tech Innovation GmbH (ProviderInformation)