-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add organizations.go
unit tests and PoolManagerController
mocks
#8
Add organizations.go
unit tests and PoolManagerController
mocks
#8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before doing an in-depth review, it would help to deduplicate some code. Left a couple of comments that should be addressed first.
The rest of the changes are similar to the one I left the comments on, so reviewing those changes will be faster once the two comments are addressed.
Thanks for the PR!
156b373
to
5f506cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot better. I know this may be a pain, but I think it's worth removing the store
mock and simply using the sql
database backend with the sqlite
driver. It would spare you from a lot of mocks, and would yield better data you can test against (ie: objects that include all fields, including IDs)
5f506cb
to
61231e6
Compare
I made this changes. Please take a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better. Just one small nit and we can merge this.
Also, update vendor with the `github.com/stretchr/testify/suite`.
61231e6
to
1a7c31c
Compare
I made this change, please take a look now. |
organizations.go
unit testsgithub.com/stretchr/testify/suite
.PoolManagerController
mocks