Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Identity Update fix #278

Merged
merged 4 commits into from
Feb 26, 2019
Merged

User Identity Update fix #278

merged 4 commits into from
Feb 26, 2019

Conversation

duemir
Copy link
Collaborator

@duemir duemir commented Jan 3, 2019

Re-submit of the #243 with Test uncommented.

Endpoitn in question https://developer.zendesk.com/rest_api/docs/support/user_identities#update-identity

It expects a JSON object with one field identity which this PR delivers. Hopefully, the automated test pass as well and #243 and #161 can be closed.

@duemir duemir requested review from aheritier and johnou January 3, 2019 22:43
Copy link
Contributor

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my side

Tests run: 67, Failures: 0, Errors: 0, Skipped: 8

I think that now we have an enterprise subscription we could activate the tests which were using these features

@duemir duemir merged commit 029b6cc into master Feb 26, 2019
@duemir duemir deleted the pull/243 branch February 26, 2019 07:03
Copy link
Contributor

@johnou johnou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants