Improve auto reload for cqrs_consume #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdjilka
changed the title
bdjilka
force-pushed
the
feature/LITE-26314_improve_consume_reload
branch
4 times, most recently
from
887dc58 to
9906a27
Compare
ffaraone
suggested changes
Jan 30, 2023
| kwargs=self.consume_kwargs, | ||
| for _ in range(self.workers): | ||
| process = start_process( | ||
| self.transport.consume, |
There was a problem hiding this comment.
The target function of start_process must be a function like the following:
def consume(**kwargs):
import django
django.setup()
from dj_cqrs import transport
transport.current_transport.consume(**kwargs)
otherwise in "spawn" mode (that is the default for the start_process function) it will not work.
| pass | ||
|
|
||
| signal.signal(signal.SIGHUP, workers_manager.reload) | ||
| signal.signal(signal.SIGHUP, workers_manager.reload) |
There was a problem hiding this comment.
No need to register signal handlers here they have already been registered in the run function of the workers manager.
bdjilka
force-pushed
the
feature/LITE-26314_improve_consume_reload
branch
from
9906a27 to
7f1932e
Compare
bdjilka
force-pushed
the
feature/LITE-26314_improve_consume_reload
branch
from
7f1932e to
602a073
Compare
ffaraone
approved these changes
Jan 30, 2023
bdjilka
changed the title
maxipavlovic
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.