Skip to content

Conversation

maxipavlovic
Copy link
Member

No description provided.

signal_type, cqrs_id, instance_data, previous_data=None, meta=None,
signal_type, cqrs_id, instance_data, previous_data=None, meta=None, queue=None,
):
""" Routes signal to model method to create/update/delete replica instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be interesting to have the new way of documentation syntax like google style even though this function is not in the documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a part of high level refactoring, I agree. But, I guess, that's a story for another PR.

@d3rky
Copy link
Contributor

d3rky commented Feb 23, 2023

Am I correct that, after Replica models (Audit) have CQRS_ONLY_DIRECT_SYNCS=True all commands from master models like

python manage.py cqrs_sync --cqrs-id product --filter='{}'

will be ignored?

And you should define the exact queue to allow Audit models to consume messages, like

python manage.py cqrs_sync --cqrs-id product --filter='{}' --queue audit

@maxipavlovic
Copy link
Member Author

Am I correct that, after Replica models (Audit) have CQRS_ONLY_DIRECT_SYNCS=True all commands from master models like

python manage.py cqrs_sync --cqrs-id product --filter='{}'

will be ignored?

And you should define the exact queue to allow Audit models to consume messages, like

python manage.py cqrs_sync --cqrs-id product --filter='{}' --queue audit

Yes, exactly.

@maxipavlovic maxipavlovic merged commit 2c6df46 into master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants