azure-vm-simple-linux #8
Conversation
|
@harijayms once we're accepted, I can handle squashing the commit for cleaner history |
|
@scottzilla @harijayms @echuvyrov - Is this a duplicate of the work on It may be worth combining them and ensuring that we are placing all these examples into the |
|
@paulbouwer @echuvyrov I thought your sample was with native disk, this one is with the managed disk. We should name accordingly. |
|
@harijayms if we renamed this to be: |
|
Also, there are a few additional files purely for enabling CI of this example and are not intended to be pushed upstream: |
|
We can push deploy.sh and after_deploy.sh as well. I feel this would be good for customers as well. The only thing that I will add is make the docker engine download as a part of it, or check for docker presence instead of failing catastrophically |
… ci process; added os_profile_linux_config
|
|
||
| storage_os_disk { | ||
| name = "${var.hostname}-osdisk1" | ||
| vhd_uri = "${azurerm_storage_account.stor.primary_blob_endpoint}${azurerm_storage_container.storc.name}/${var.hostname}-osdisk1.vhd" |
There was a problem hiding this comment.
I thought we didnt need to specify VHD URI for Managed disk ,
|
|
||
| storage_data_disk { | ||
| name = "${var.hostname}-disk2" | ||
| vhd_uri = "${azurerm_storage_account.stor.primary_blob_endpoint}${azurerm_storage_container.storc.name}/${var.hostname}-disk2.vhd" |
|
|
||
| # cleanup deployed azure resources | ||
| docker run --rm -it \ | ||
| azuresdk/azure-cli-python \ |
There was a problem hiding this comment.
We should use the az cli to validate that the resource was created or add that in deploy.sh , how would we know if the resource was created?
| /bin/terraform validate; \ | ||
| /bin/terraform plan -out=out.tfplan -var dns_name=$KEY -var hostname=$KEY -var resource_group=$KEY -var admin_password=$PASSWORD; \ | ||
| /bin/terraform apply out.tfplan" | ||
|
|
There was a problem hiding this comment.
Add terraform show here, it will be good to record it in the logs
| } | ||
|
|
||
| resource "azurerm_storage_container" "storc" { | ||
| name = "${var.hostname}-vhds" |
There was a problem hiding this comment.
We dont need this container now right?
|
@harijayms |
| } | ||
|
|
||
| variable "storage_account_type" { | ||
| description = "Specifies the name of the storage account. Changing this forces a new resource to be created. This must be unique across the entire Azure service, not just within the resource group." |
There was a problem hiding this comment.
Description is wrong
| } | ||
|
|
||
| variable "vm_size" { | ||
| description = "Specifies the name of the virtual machine resource. Changing this forces a new resource to be created." |
There was a problem hiding this comment.
Wrong description
|
Thank you @StephenWeatherford, the descriptions have been updated accordingly. |
|
@scottzilla I dont see the CI running terraform for this, what am I missing? |
|
@harijayms |
Terraform HCL version of ARM 101-vm-simple-linux quickstart template
CI enabled.