Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #52 - Change contexts temp value according jasmine script sources #53

Closed
wants to merge 1 commit into from

Conversation

schorfES
Copy link

This should fix the issue when a wrong path to require.js lib is used
when jasmines outfile option is specified.

This should fix the issue when a wrong path to require.js lib is used
when jasmines outfile option is specified.
@cloudchen
Copy link
Owner

Thanks for you attention and PR.
Because this template has no idea of where the location of spec runner is, which depends on exporting of grunt-contrib-jasmine, I have sent PR to request needed information by grunt-contrib-jasmine. We can proceed as long as that PR is accepted.

@schorfES
Copy link
Author

Yes, you're right. Doing it this way would be a better approach!

But when it's added into the grunt-contrib-jasmine task, we have to keep in mind to calculate the relative path to the Gruntfile.js where the .gruntdirectory will be located.

Will the temporary .grunt directory always be in the same location as the Gruntfile.js? So it's possible to simply use __dirname to calculate the correct relative location?

@cloudchen
Copy link
Owner

__dirname doesn't work for that. It always returns node_modules/grunt-template-jasmine-requirejs/src which doesn't help.

What we only need to calculate is that the relative path of require.js file to spec_runner.html.

The location of .grunt folder doesn't matter I think.

@schorfES
Copy link
Author

Okay, my bad!
"What we only need to calculate is that the relative path of require.js file to spec_runner.html." - Thats right. I've seen your pull request has been put into the upcoming version 2.0...

@cloudchen
Copy link
Owner

Fixed in v0.1.10

@cloudchen cloudchen closed this Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants