Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an option to override the default SpecRunner template file #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davyboyhayes
Copy link

We had an issue whereby the requirejs code at the bottom of the outputted _SpecRunner.html file was including all of the jasmine.src files, that we actually didn't need to be included in the SpecRunner file, but we needed to specify them because https://github.com/maenu/grunt-template-jasmine-istanbul#templateoptionsfiles doesn't appear to instrument any of these files, only the ones in jasmine.src.

One bug aside, I can see use cases where users may want to customize their SpecRunner.html file

@amireh
Copy link

amireh commented Aug 20, 2014

I've run into exactly the same issue, but I solved it by adding a skipSources option that prevents the template from including the sources in the require() call.

I can issue a PR if interested.

@Louisblack
Copy link

I know this is an old request but it gets another vote from me.
We're also having trouble with Istanbul coverage using this template.
We're also using Squire to mock some dependencies which causes the requirejs callback to fire multiple time so have needed to modify the template to deal with this.

Pulling latest from cloudchen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants