Updated code to work with Grunt 1.0. #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2016 17:12
|
Apart from the NPM errors, looks good to me |
|
I did the same for the templating, but I moved the lodash to grunt itself because other dependencies are using it as well. Can this be merged ? It's blocking :-) |
|
👍 |
added 2 commits
June 1, 2016 15:42
Update Travis and RequireJs dependency versions Update Travis and RequireJs dependency versions
|
@mikeapr4 All good :D I was forgetting the Travis deps. |
|
Ping @cloudchen :) Should we clone this if is not maintained :( |
|
what did you guys do ? cloned it to a new repository. no response from maintainers? |
|
@pksorensen I'm using my own clone now. With the changes from this PR. |
dabarbanel
approved these changes
Feb 16, 2017
wpwood
pushed a commit
to wpwood/grunt-template-jasmine-requirejs
that referenced
this pull request
Sep 7, 2017
|
are you going to merge this ? |
added 8 commits
January 19, 2018 11:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the code to make it work with the latest Grunt 1.0
Also Lodash is now a dependency as per Grunt best practices since 1.0