Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping several go deps and fixing mocks for them #278

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

CerealBoy
Copy link
Member

  • aws-sdk-go
  • cors
  • zap

Replaces #275 #276 #277

@CerealBoy CerealBoy added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 18, 2024
@CerealBoy CerealBoy self-assigned this Apr 18, 2024
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cloudcloud/roadie/pkg/sources 68.04% (ø)

Coverage by file
Changed File Coverage Δ Total Covered Missed 🤖
github.com/cloudcloud/roadie/pkg/sources/s3_test.go 0.00% (ø) 0 0 0
github.com/cloudcloud/roadie/pkg/sources/s3iface_test.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@CerealBoy CerealBoy merged commit eacf51d into main Apr 18, 2024
5 checks passed
@CerealBoy CerealBoy deleted the fix/bump-go-deps branch April 18, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code release-heading/dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant