Merge pull request #2 from clouddrove/CD-147

fix labels managedby variables
clouddrove · Mar 24, 2020 · 1c8ff53 · 1c8ff53
2 parents 434a6e3 + 0916e9d
commit 1c8ff53
Show file tree

Hide file tree

Showing 6 changed files with 103 additions and 95 deletions.
diff --git a/README.md b/README.md
diff --git a/README.yaml b/README.yaml
@@ -37,7 +37,7 @@ usage : |-
   ### Basic Example
   ```hcl
     module "api-gateway" {
-      source                          = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.0"
+      source                          = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.2"
       name        = "api-gateway"
       application = "clouddrove"
       environment = "test"
@@ -95,7 +95,7 @@ usage : |-
   ### Complete Example
   ```hcl
     module "api-gateway" {
-      source                          = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.0"
+      source                          = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.2"
       name        = "api-gateway"
       application = "clouddrove"
       environment = "test"

diff --git a/_example/basic/example.tf b/_example/basic/example.tf
@@ -3,7 +3,7 @@ provider "aws" {
 }
 
 module "api-gateway" {
-  source      = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.0"
+  source      = "../../"
   name        = "api-gateway"
   application = "clouddrove"
   environment = "test"

diff --git a/_example/complete/example.tf b/_example/complete/example.tf
@@ -3,7 +3,7 @@ provider "aws" {
 }
 
 module "api-gateway" {
-  source = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.0"
+  source = "../../"
 
   name        = "api-gateway"
   application = "clouddrove"

diff --git a/main.tf b/main.tf
@@ -11,6 +11,7 @@ module "labels" {
   name        = var.name
   application = var.application
   environment = var.environment
+  managedby   = var.managedby
   label_order = var.label_order
 }
 
@@ -144,7 +145,7 @@ resource "aws_api_gateway_method_response" "options_200" {
     "method.response.header.Access-Control-Allow-Credentials" = true
   }
 
-  depends_on = ["aws_api_gateway_method.options_method"]
+  depends_on = [aws_api_gateway_method.options_method]
 }
 
 resource "aws_api_gateway_integration" "options_integration" {
@@ -156,7 +157,7 @@ resource "aws_api_gateway_integration" "options_integration" {
   type             = "MOCK"
   content_handling = "CONVERT_TO_TEXT"
 
-  depends_on = ["aws_api_gateway_method.options_method"]
+  depends_on = [aws_api_gateway_method.options_method]
 }
 
 resource "aws_api_gateway_integration_response" "options_integration_response" {
@@ -173,8 +174,8 @@ resource "aws_api_gateway_integration_response" "options_integration_response" {
   }
 
   depends_on = [
-    "aws_api_gateway_method_response.options_200",
-    "aws_api_gateway_integration.options_integration",
+    aws_api_gateway_method_response.options_200,
+    aws_api_gateway_integration.options_integration,
   ]
 }
 

diff --git a/variables.tf b/variables.tf
@@ -42,6 +42,12 @@ variable "tags" {
   description = "Additional tags (e.g. map(`BusinessUnit`,`XYZ`)."
 }
 
+variable "managedby" {
+  type        = string
+  default     = "anmol@clouddrove.com"
+  description = "ManagedBy, eg 'CloudDrove' or 'AnmolNagpal'."
+}
+
 # Module      : Api Gateway
 # Description : Terraform Api Gateway module variables.
 variable "enabled" {