Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump clouddrove/acm/aws from 1.3.0 to 1.4.1 in /_examples/vpc_link_api #50

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 9, 2023

Bumps clouddrove/acm/aws from 1.3.0 to 1.4.1.

Release notes

Sourced from clouddrove/acm/aws's releases.

1.4.1

πŸ› Bug Fixes

1.4.0

No release notes provided.

Changelog

Sourced from clouddrove/acm/aws's changelog.

Changelog

All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [clouddrove/acm/aws](https://github.com/clouddrove/terraform-aws-acm) from 1.3.0 to 1.4.1.
- [Release notes](https://github.com/clouddrove/terraform-aws-acm/releases)
- [Changelog](https://github.com/clouddrove/terraform-aws-acm/blob/master/CHANGELOG.md)
- [Commits](clouddrove/terraform-aws-acm@1.3.0...1.4.1)

---
updated-dependencies:
- dependency-name: clouddrove/acm/aws
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team October 9, 2023 01:54
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 9, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 9, 2023

Dependabot tried to add @approvers as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/clouddrove/terraform-aws-api-gateway/pulls/50/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the clouddrove/terraform-aws-api-gateway repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

@anmolnagpal
Copy link
Contributor

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM Access logging is not configured. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:97-139
────────────────────────────────────────────────────────────────────────────────
   97  β”Œ resource "aws_apigatewayv2_stage" "default" {
   98  β”‚   count = var.enabled && var.create_default_stage_enabled ? 1 : 0
   99  β”‚ 
  100  β”‚   api_id      = aws_apigatewayv2_api.default[0].id
  101  β”‚   name        = format("%s-stage", module.labels.id)
  102  β”‚   auto_deploy = false
  103  β”‚   dynamic "access_log_settings" {
  104  β”‚     for_each = var.access_log_settings
  105  β””     content {
  ...  
────────────────────────────────────────────────────────────────────────────────
          ID aws-api-gateway-enable-access-logging
      Impact Logging provides vital information about access and usage
  Resolution Enable logging for API Gateway stages

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/api-gateway/enable-access-logging/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/apigatewayv2_stage#access_log_settings
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             239.902Β΅s
  parsing              71.36925ms
  adaptation           231.802Β΅s
  checks               14.128889ms
  total                85.969843ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     64
  files read           4

  results
  ──────────────────────────────────────────
  passed               1
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  1 passed, 1 potential problem(s) detected.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 13, 2023

Looks like clouddrove/acm/aws is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Oct 13, 2023
@dependabot dependabot bot deleted the dependabot/terraform/_examples/vpc_link_api/clouddrove/acm/aws-1.4.1 branch October 13, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants