Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/rest api #59

Merged
merged 18 commits into from
Mar 11, 2024
Merged

Feat/rest api #59

merged 18 commits into from
Mar 11, 2024

Conversation

Aatishsharma77
Copy link
Contributor

@Aatishsharma77 Aatishsharma77 commented Jan 19, 2024 •
edited
Loading

what

Feature

  • Add Rest API and Private Rest API
  • Add Cloudwatch log group and KMS keys.

Fixes

  • Payload version in HTTP API

@clouddrove-ci clouddrove-ci self-assigned this Jan 19, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 19, 2024
View reviewed changes
_examples/complete/private-rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/private-rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/private-rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/private-rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/private-rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/private-rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/private-rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/private-rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/rest-api-gateway/example.tf Fixed Show fixed Hide fixed
_examples/complete/rest-api-gateway/example.tf Fixed Show fixed Hide fixed
@Aatishsharma77
feat: terrafrom script for rest-api and rest-api private
302cbdc
@Aatishsharma77
feat: terrafrom script for rest-api and rest-api private
191b4b0
@Aatishsharma77
feat: terrafrom script for rest-api and rest-api private
990a4f5
@Aatishsharma77
feat: terrafrom script for rest-api and rest-api private
be4d8ff
@Aatishsharma77
feat: terrafrom script for rest-api and rest-api private
0621539
@Aatishsharma77
fix- if you are fixing changes other than terraform code {such as tfs…
7d82204 
…ec, tfchecks, readme issues and all
@Aatishsharma77
fix: update region in all _examples
3f5c539
@Aatishsharma77
fix: update service name in _examples
737aaef
@Aatishsharma77
feat: update payload version in http api gateway
6e353f9
@Aatishsharma77
feat: update payload version in http api gateway
4d3e4fa
@Aatishsharma77
feat: add cloudwatch log group and kms in rest api gateway
494adf3
@Aatishsharma77
feat: add cloudwatch log group and kms in rest api gateway
655afcf
@Aatishsharma77
feat: add cloudwatch log group and kms key
c388305
@h1manshu98
Copy link
Member

Please update the description with all the changes you have made in this PR

h1manshu98
h1manshu98 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aatishsharma77 Aatishsharma77 self-assigned this Jan 30, 2024
@Aatishsharma77 Aatishsharma77 added the bug Something isn't working label Jan 30, 2024
@Aatishsharma77 Aatishsharma77 added enhancement New feature or request deployment labels Jan 30, 2024
h1manshu98
h1manshu98 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

omsharma07
omsharma07 approved these changes Feb 20, 2024
View reviewed changes
Copy link

@omsharma07 omsharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaibhav7797
vaibhav7797 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci merged commit 42e5ae3 into master Mar 11, 2024
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/rest-api branch March 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@omsharma07 omsharma07 omsharma07 approved these changes

@13archit 13archit Awaiting requested review from 13archit

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@clouddrove-ci clouddrove-ci

@Aatishsharma77 Aatishsharma77

Labels
bug Something isn't working deployment enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Aatishsharma77 @h1manshu98 @omsharma07 @themaniskshah @vaibhav7797 @clouddrove-ci