Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable attribute for all resources #22

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix: enable attribute for all resources #22

merged 2 commits into from
Oct 3, 2023

Conversation

h1manshu98
Copy link
Member

  • Previously, setting enable = false was not destroying all the resources created by client-vpn module.
  • Added enable attribute in count = field of all the resources

@h1manshu98 h1manshu98 requested a review from a team September 28, 2023 17:22
@clouddrove-ci clouddrove-ci self-assigned this Sep 28, 2023
@h1manshu98 h1manshu98 self-assigned this Sep 28, 2023
anmolnagpal
anmolnagpal previously approved these changes Sep 29, 2023
View reviewed changes
nikitadugar
nikitadugar previously approved these changes Sep 29, 2023
View reviewed changes
@13archit 13archit dismissed stale reviews from nikitadugar and anmolnagpal via 5b7e77f October 3, 2023 09:56
d4kverma
d4kverma approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@d4kverma d4kverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themaniskshah
themaniskshah approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@13archit 13archit merged commit 46cd712 into master Oct 3, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/enable-attribute branch October 3, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themaniskshah themaniskshah themaniskshah approved these changes

@d4kverma d4kverma d4kverma approved these changes

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@nikitadugar nikitadugar Awaiting requested review from nikitadugar

Assignees

@h1manshu98 h1manshu98

@clouddrove-ci clouddrove-ci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@h1manshu98 @anmolnagpal @nikitadugar @themaniskshah @d4kverma @clouddrove-ci @13archit