Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed typo in cloudtrail key policy #33

Closed
wants to merge 1 commit into from
Closed

Conversation

nileshgadgi
Copy link
Contributor

what

  • Fixed Typo in the cloudtrail key policy

why

  • Was having issue while creating cloudtrail and was not able to manager cloudtrail using terarform in projects.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 LOW Log group is not encrypted. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:71-76
────────────────────────────────────────────────────────────────────────────────
   71    resource "aws_cloudwatch_log_group" "cloudtrail_events" {
   72      count             = var.enabled ? 1 : 0
   73      name              = var.cloudwatch_logs_group_name
   74      retention_in_days = var.cloudwatch_logs_retention_in_days
   75      tags              = module.labels.tags
   76    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-cloudwatch-log-group-customer-key
      Impact Log data may be leaked if the logs are compromised. No auditing of who have viewed the logs.
  Resolution Enable CMK encryption of CloudWatch Log Groups

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/cloudwatch/log-group-customer-key/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_group#kms_key_id
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             96.922µs
  parsing              107.493913ms
  adaptation           146.195µs
  checks               14.760487ms
  total                122.497517ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     53
  files read           4

  results
  ──────────────────────────────────────────
  passed               0
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  1

  1 potential problem(s) detected.

@nileshgadgi nileshgadgi deleted the fix/trail branch May 14, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants